fix(ng-dev): improve spinner experience when executed in a CI environment #2426
Conversation
…ment Improve the spinner experience in a CI environment so that it does not show the same message repeatedly, but also continues to show output to prevent CI environments from treating the execution as inactive.
| import {green, red} from './logging.js'; | ||
|
|
||
| /** Whether execution is in a CI environment. */ | ||
| const IS_CI = process.env['CI']; |
There was a problem hiding this comment.
At this point in time we keep making the spinner more complicated. Should we consider just using a library here?
There was a problem hiding this comment.
This is still markedly less complicated than a library has, we can if you would like, but I do personally like the total control we have in this case. But if you feel strongly I am happy to look into options for us.
|
This PR was merged into the repository by commit 11967c8. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
Improve the spinner experience in a CI environment so that it does not show the same message repeatedly, but also continues to show output to prevent CI environments from treating the execution as inactive.